Skip to content

Feat/df 529 change lat long 2#239

Merged
davidjamesstone merged 6 commits intofeat/df-529-change-lat-longfrom
feat/df-529-change-lat-long-2
Nov 7, 2025
Merged

Feat/df 529 change lat long 2#239
davidjamesstone merged 6 commits intofeat/df-529-change-lat-longfrom
feat/df-529-change-lat-long-2

Conversation

@davidjamesstone
Copy link
Copy Markdown
Contributor

@davidjamesstone davidjamesstone commented Nov 6, 2025 •
edited
Loading

Proposed change

Jira ticket: https://eaflood.atlassian.net/browse/DF-529

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 6, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
8 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube Cloud

@davidjamesstone davidjamesstone merged commit 54528fa into feat/df-529-change-lat-long Nov 7, 2025
10 checks passed
@davidjamesstone davidjamesstone deleted the feat/df-529-change-lat-long-2 branch November 7, 2025 09:01
mokhld added a commit that referenced this pull request Nov 7, 2025
@mokhld @davidjamesstone
feat: Update latitude and longitude validation ranges in LatLongField (…
13d1cf3 
…#238)

* feat: Update latitude and longitude validation ranges in LatLongField

* refactor: sonar changes (coverage and duplicated lines)

* Feat/df 529 change lat long 2 (#239)

* Fix unicorn form

* Revert changes to NumberField

* Remove minLength and maxLength from EN field

* Remove minPrecision, minLength and maxLength from LL field

* Update NGR and OS ref fields

* Remove case insensitive flag

---------

Co-authored-by: David Stone <davidjamesstone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mokhld mokhld mokhld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidjamesstone @mokhld